fix: outExtension for generating dts files by rollup #1053
+27
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
timdorr
added a commit
to reduxjs/redux
that referenced
this pull request
Mar 20, 2024
Waiting on egoist/tsup#1053 to revert back to .d.ts extension
Contributor
|
Is there anything we can do to help facilitate this change? |
|
I tried upgrading storybook's monorepo to TSup 8 and it failed, and it's likely this would allow us to upgrade. |
115a451 to
57654f6
Compare
|
Hi! Any plans to deploy this? Would greatly help the need to customize dts file ext. Thanks! |
|
@sxzz Could you please review & merge it? |
|
Hi, any update? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
outExtensionfor generated dts files? #939Description:
Rollup operates in a Node.js Worker threads and can only receive messages as plain objects (without functions). In
tsup.config, outExtension is a function. Therefore if we send the config "as is", we encounter a DataCloneError.Solution:
Execute
outExtensionbefore sending message to rollup worker thread and send the array withoutExtensionresults.