fix: change fast-glob to globby #159
Conversation
|
I found these problems primarily while making a GitHub Action in Linux, while my personal computer is Windows, and I encountered this weird bug that in Windows at least fast-glob respects the I made another branch on the same repo showing the differences, and you can see that fast-glob is working very inconsistently between operative systems. tsup-globby windows And I think it's important to point up that the declarations files are not working properly at all, even with preserveModules: true 👎, maybe because some filename collisions |
|
So maybe remove |
I agree, but preserveModule tries to solve a different problem which is that without it the intermediate modules are not typed, but anyways, I will remove the preserveModule from this PR, and in my projects I had to stop using |
413414b to
a1e19cf
Compare
|
🎉 This PR is included in version 3.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Right now the globs in the entry points need to be almost hard-coded since fast-glob doesn't expand the directories, but globby does, which actually uses fast-glob inside, and uses the same API, so this is a win-win. You can test this making some folders with depth, like src/a/b/index.ts while also having a src/index.ts, fast-glob won't find them.
And also the dts building using rollup was not preserving the modules structures and they were not actually matching with the normal js building files, just adding preserveModules fixed it.I also made a published fork with these changes, so you can test them easily.
tsup-globby