internal/mux: remove a hack to avoid goroutines for Windows

Windows timer resolution was not good and caused some issues (hajimehoshi/ebiten#1768), and `mux.playerImpl.Play` has a hack to avoid goroutines for Windows.

https://github.com/ebitengine/oto/blob/457cd3ebf3f3fdb6605ca9f382bad90e6de49b54/internal/mux/mux.go#L216-L222

As of Go 1.23, Windows uses much better timer reoslutions https://github.com/golang/go/issues/44343 so we might no longer need this hack in the future.

	// Goroutines don't work effiently on Windows. Avoid using them (hajimehoshi/ebiten#1768).
	if runtime.GOOS == "windows" {
	p.m.Lock()
	defer p.m.Unlock()

	p.playImpl()
	} else {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

internal/mux: remove a hack to avoid goroutines for Windows #235

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

internal/mux: remove a hack to avoid goroutines for Windows #235

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions