Adds score variable to matched / sorted results and multi model support #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just added this multi model support as well - tests written / all passing with rake test |
Author
|
Looks like the CI is busted - here's my local result |
Owner
|
CI has been intermittently failing for some Ruby/Rails versions for a while. Not sure why, they always run fine locally. The score instance variable patch is almost insta-merge, though I'm not sure about the name as it seems it might clash with other libraries or even user defined attributes. I'd prefer not to add yet more configuration for this, perhaps calling it search_score or something less generic. I'll need to look at the Multi-Model patch more closely, but it looks great on first pass. Thanks! |
Author
|
Please see: Also: |
Author
|
Should I just close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the matching score available for use inside the instance.