Fix for multiple negative words queries #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f them, not all of them
Owner
|
So if we have four documents:
Then the search: cat -dog -bird |
Contributor
Author
|
@dougal No, my understanding of this query is: documents with |
Contributor
Author
|
Ok, since the semantics of those kind of queries are open to interpretations, I took a different approach. I refactored the Forget about this PR, I'll send a new one with the new code which will not break existing queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying with multiple negative words, I think that the expected behaviour is to match documents without any of them, not all of them.
Example:
dog -cat -birdshould match all documents withdogbut withoutcatorbirdCurrently it matches all documents with
dogwithoutcatANDbird