Fix Storage#write_file to be thread-safe #34
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage#write_file is not thread-safe.
The bug comes out when multiple threads are trying to write data into one index file.
When such situation occurs, one thread moves
tmp_filetonew_filebyFileUtils.mv. At the same time second thread tries to move temporary file tonew_filetoo, but temporary file not exists already, so method fails withErrno::ENOENT: No such file or directory.You can reproduce it with concurrent creating indexed model instances, something like this:
One possible fix is to create temporary file with uniq name. It is possible to create it via
Tempfileclass or manually, as in pull request.With this fix,
FileUtils.mvwill move only temporary file from the current thread.