这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@novalis
Copy link

@novalis novalis commented Feb 13, 2012

No description provided.

@dougal
Copy link
Owner

dougal commented Feb 13, 2012

This is great!

Some far-reaching implementation changes, I'll set some time aside to read over them later this week.

Cheers.

@novalis
Copy link
Author

novalis commented Feb 13, 2012

I'm not 100% sure I chose the correct approach, and I think there may be a simpler approach possible. But I didn't fully understand the codebase when I started, so this is what ended up happening. One thing that confused me was the use of the atom variable name to mean both a SearchAtom and a single word, so I changed instances of the latter to "token".

@dougal
Copy link
Owner

dougal commented Nov 25, 2012

Hi there.

"This week" has turned into "This year".

The "do not match quoted phrases across field boundaries" commit is great, I have some tests for this already, hopefully this will satisfy those.

I had a play with implementing stemmer support today, first on my own, then I read through your implementation. While I can see the usefuleness of it, it does add a lot of complexity at all levels of the library. It also has quite an effect on index sizes. I'll probably leave this for just now, though I am tempted to come back to it in the future.

@dougal dougal closed this Dec 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants