Added a new paginator, the 'generic paginator'. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gination when will_paginate is not used by the application.
Collaborator
Author
|
Ugh, sorry, still no tests. |
Owner
|
WillPaginate support is only loaded when it's available, so perhaps this could be loaded as the alternate, rather than configuring it. I can't see a situation where you have WP, but don't want to use it. |
Collaborator
Author
|
I believe that kaminari conflicts with will_paginate and this arose out of that requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a work in progress so feel free to discuss this with me (first of all it needs a test!).
Added a new paginator, the 'generic paginator' which handles basic pagination when will_paginate is not used by the application.