这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: allow deferredFields works with fragment #9565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2025
Merged

fix: allow deferredFields works with fragment #9565

merged 4 commits into from
Nov 13, 2025
+72 −8

Conversation

@ludusrusso
Copy link
Contributor

@ludusrusso ludusrusso commented Jul 25, 2023 •
edited
Loading

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

With this PR, __meta__.deferredFields are generated also in case of fragment with deferred nested fragment, this will fix an issue with isFragmentReady that returns always true in that case

Related #9564

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I've updated client preset tests
  • Test locally with example repo

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 384d582

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ludusrusso ludusrusso force-pushed the defer-with-fragment branch from 1399d0f to 3a7bd84 Compare July 26, 2023 13:43
@Urigo Urigo requested review from beerose and n1ru4l July 27, 2023 20:00
@ludusrusso
Copy link
Contributor Author

ludusrusso commented Sep 11, 2023

Any news about this PR?

beerose
beerose approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delays!

lgtm

@beerose beerose requested a review from saihaj October 24, 2023 18:46
@2snEM6
Copy link

2snEM6 commented Dec 24, 2023

Hi! any news regarding this PR?

@ludusrusso
Copy link
Contributor Author

ludusrusso commented Jan 27, 2024

Still waiting for approval! @beerose there is something I can do?

@2snEM6
Copy link

2snEM6 commented Apr 30, 2025 •
edited
Loading

Is there something I can do to merge this PR? @n1ru4l @saihaj . This feature is quite powerful. If I can be of any help, let me know :)

@saihaj saihaj requested a review from eddeee888 May 6, 2025 11:13
@ludusrusso
Copy link
Contributor Author

ludusrusso commented Nov 10, 2025

@2snEM6 @beerose @slaytanic @dittos let me know if I can do something about this PR, otherwise I'll close it!

@eddeee888
Copy link
Collaborator

eddeee888 commented Nov 11, 2025

Hi @ludusrusso , let me take a look 👀

@eddeee888 eddeee888 self-assigned this Nov 11, 2025
eddeee888
eddeee888 approved these changes Nov 13, 2025
View reviewed changes
Copy link
Collaborator

@eddeee888 eddeee888 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix the immediate problem, thank you!

Side note: I'm not 100% familiar with fragments but I think there are also a few different variants for fragment that may need the same treatment? 🤔

e.g.

  • Inline fragment
something {
  ... on Foo @defer {
    id
  }
}
  • and inline fragment without type
something {
  ... @defer {
    id
  }
}

This can be done later if it's truly a problem though.

@eddeee888 eddeee888 merged commit d359d0b into dotansimha:master Nov 13, 2025
20 checks passed
@eddeee888 eddeee888 mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddeee888 eddeee888 eddeee888 approved these changes

@n1ru4l n1ru4l Awaiting requested review from n1ru4l

@saihaj saihaj Awaiting requested review from saihaj

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eddeee888 eddeee888

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ludusrusso @2snEM6 @eddeee888 @beerose