这是indexloc提供的服务，不要输入任何密码
Skip to content

Feed cleanup #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2020
Merged

Feed cleanup #814

merged 5 commits into from
Mar 26, 2020

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Mar 25, 2020

Move away from blob feeds and attempt to move away from myget feeds.

@mmitche
Feed cleanup
c54862c 
Move away from blob feeds and attempt to move away from myget feeds.
@mmitche mmitche requested a review from brettfo March 25, 2020 16:42
brettfo
brettfo requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@brettfo brettfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update $(RestoreSources) in eng/Versions.props.

@mmitche
Copy link
Member Author

mmitche commented Mar 25, 2020

@brettfo I'm going to update System.CommandLine to a version that is released (0.3.0-alpha.20070.2). Sound good?

@brettfo
Copy link
Member

brettfo commented Mar 25, 2020

I'll deflect the System.CommandLine question to @jonsequitur.

@mmitche
Copy link
Member Author

mmitche commented Mar 25, 2020

I'll deflect the System.CommandLine question to @jonsequitur.

FYI the current verison appears to be one day later than that.

@jonsequitur
Copy link
Contributor

jonsequitur commented Mar 25, 2020

@mmitche System.CommandLine should be at or above version 2.0.0-beta1.20161.1. System.CommandLine.Rendering should be at or above 0.3.0-alpha.20161.1. These were published in the corefx feed, I believe.

@mmitche
Copy link
Member Author

mmitche commented Mar 25, 2020

@mmitche System.CommandLine should be at or above version 2.0.0-beta1.20161.1. System.CommandLine.Rendering should be at or above 0.3.0-alpha.20161.1. These were published in the corefx feed, I believe.

Looks like all the newer versions are on dotnet5, I'll do an update.

@brettfo
Copy link
Member

brettfo commented Mar 25, 2020

@jonsequitur I'm OK with the changes, do the command line updates look good to you?

@mmitche mmitche merged commit 1bcbcd7 into master Mar 26, 2020
@brettfo brettfo deleted the mmitche-patch-1 branch April 2, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettfo brettfo brettfo requested changes

@jonsequitur jonsequitur jonsequitur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmitche @brettfo @jonsequitur