Fix Issue #624 - #r nuget selects oldest package when version is not… #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
requested changes
Dec 12, 2019
| } | ||
|
|
||
| [Fact] | ||
| public async Task issue_624() |
Member
There was a problem hiding this comment.
More descriptive test name. You can link to the fixed issue number in the attribute.
brettfo
approved these changes
Dec 12, 2019
jonsequitur
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624 - #r loads the oldest NuGet from the feed
By default when version is not specified nuget selects the oldest value in the feed. This behaviour is not appropriate in a scripting environment when a developer is more likely to want the latest and greatest version.
This change uses "*" select oldest stable version for the version value, when no version is specified.