Test case for System.Text.Json #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Dec 12, 2019
|
|
||
| await SubmitCode(kernel, source); | ||
|
|
||
| KernelEvents |
Contributor
There was a problem hiding this comment.
You can also do this, which will be more informative if the event is missing:
KernelEvents
.Should()
.ContainSingle<ReturnValueProduced>()
.Which
.Value
.Should()
.BeTrue();
jonsequitur
approved these changes
Dec 12, 2019
Contributor
Author
|
sorry to be a pest can we merge this please, Github is not my friend. Thanks Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case for using System.Text.Json.
Fixes #637 - Unable to use System.Text.Json iin Jupyter c# kernel #637
It now works, add a test case so that we keep it working.