[WIP] #r nuget improvements #586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d24b9fe to
cc66b52
Compare
colombod
reviewed
Nov 1, 2019
NotebookExamples/Untitled.ipynb
Outdated
| @@ -0,0 +1,73 @@ | |||
| { | |||
e11ac63 to
62d1271
Compare
colombod
reviewed
Nov 2, 2019
| } | ||
|
|
||
| public ScriptOptions ScriptOptions { get; private set; } = | ||
| public ScriptOptions ScriptOptions { get; } = |
Member
There was a problem hiding this comment.
Do we need this property as public?
c5b82bc to
b61aadc
Compare
Member
|
Should also fix https://github.com/dotnet/try/issues/458. |
0917a4c to
0bcdd01
Compare
Contributor
Author
|
Closing because #600 is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #354, #583, #582, and #584.