handle compilation failures in the F# kernel #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
Oct 10, 2019
| let formattedValues = FormattedValue.FromObject(value) | ||
| context.Publish(ReturnValueProduced(value, codeSubmission, formattedValues)) | ||
| | None -> () | ||
| context.Complete() |
Contributor
There was a problem hiding this comment.
@brettfo, is context.Complete() not needed when we match | Error?
Contributor
There was a problem hiding this comment.
It shouldn't be. This part of the API is hard to understand, though. Ideally (in a future, better version of this API) the context is completed automatically when the handler has exited and this method call should become implicit or unnecessary and go away. The more interesting case is when you want the event channel to remain alive after the handler has exited, e.g. publishing or streaming data back to the client.
colombod
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes bringing more language agnostic tests in line.