terminal formatter and mime type support #516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c51c42 to
5cf10b7
Compare
jonsequitur
reviewed
Oct 10, 2019
| traceBack.Add(commandFailed.Message); | ||
| break; | ||
| default: | ||
| traceBack.Add("Unhandled Exception"); |
Contributor
There was a problem hiding this comment.
Does the output look correct if the traceback is added as a single string with line breaks?
jonsequitur
reviewed
Oct 10, 2019
| }); | ||
| } | ||
|
|
||
| public const string MimeType = "text/vt100"; |
Contributor
There was a problem hiding this comment.
This is probably not the correct name for this mime type, since VT-100 is really a subset of the ANSI escape sequences that might be used.
jonsequitur
reviewed
Oct 10, 2019
| _format = format; | ||
| } | ||
|
|
||
| public override void Format(T instance, TextWriter writer) |
jonsequitur
reviewed
Oct 10, 2019
| { | ||
| private readonly Action<T, TextWriter> _format; | ||
|
|
||
| public TerminalFormatter(Action<T, TextWriter> format) |
jonsequitur
reviewed
Oct 10, 2019
| private static ITypeFormatter<T> CreateForObject(bool includeInternals) | ||
| { | ||
| var members = typeof(T).GetAllMembers(includeInternals) | ||
| .GetMemberAccessors<T>(); |
Contributor
There was a problem hiding this comment.
A better approach here would be to use the Destructurer class, which is what the HtmlFormatter uses to build up the table.
6aebe70 to
7122da7
Compare
31d7010 to
b37552a
Compare
104d503 to
0f47a1a
Compare
0f47a1a to
1a2d831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide vt100 formatting in rendering