preserve ordering of commands when splitting a submission #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
Oct 1, 2019
| [Fact] | ||
| public async Task When_SubmitCode_command_adds_packages_to_csharp_kernel_then_the_submission_is_not_passed_to_csharpScript() | ||
| { | ||
| var cSharpKernel = new CSharpKernel(); |
Contributor
There was a problem hiding this comment.
I expect there will be an F# version too:
perhaps:
var languageKernel = new CSharpKernel();
using var events = languageKernel.KernelEvents.ToSubscribedList();
var kernel = new CompositeKernel
{
languageKernel.UseNugetDirective()
};
c900bce to
aabce76
Compare
aabce76 to
45533eb
Compare
cde5bca to
da9b524
Compare
243a54d to
4aad7b8
Compare
4aad7b8 to
706e9bf
Compare
706e9bf to
c0ae958
Compare
colombod
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.