Progress reporting for #r nuget #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2019 12:32
colombod
reviewed
Sep 9, 2019
| events | ||
| .First() | ||
| .Should() | ||
| .Match(e => e is DisplayedValueProduced && ((DisplayedValueProduced)e).Value.ToString().Contains("Attempting to install")); |
Member
There was a problem hiding this comment.
probably here we should assert on a sequence of events
jonsequitur
reviewed
Sep 9, 2019
| if (!string.IsNullOrWhiteSpace(package.PackageVersion)) | ||
| { | ||
| message += $", version {package.PackageVersion}"; | ||
| } |
Contributor
There was a problem hiding this comment.
Can we also get a notification about which actual version was installed in the case where the version was not specified?
Author
There was a problem hiding this comment.
Will do this in a subsequent change
jonsequitur
reviewed
Sep 9, 2019
| } | ||
| else | ||
| { | ||
| context.Publish(new DisplayedValueProduced($"Failed to add reference to package {package.PackageName}", context.Command)); |
Contributor
There was a problem hiding this comment.
When it fails, why does it fail, and is there additional information we can surface?
jonsequitur
reviewed
Sep 9, 2019
colombod
approved these changes
Sep 9, 2019
jonsequitur
reviewed
Sep 10, 2019
| message += $", version {package.PackageVersion}"; | ||
| } | ||
|
|
||
| var key = message; |
Contributor
There was a problem hiding this comment.
Maybe call this valueId so it's clearer what its significance is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.