Publish interactive packages #427
Conversation
colombod
left a comment
There was a problem hiding this comment.
can we rename / address the ml.agent.tools? I don't think is ideal to ship / package like this
jonsequitur
left a comment
There was a problem hiding this comment.
Let's take a look at how to avoid publishing a package for MLS.Agent.Tools.
|
The latest commit d9fd5ef adds a "beta" label for the library nuget packages and maintains the current behavior for the tool. |
|
Many thanks to @brettfo for helping to demistify the arcade stuff🥇 |
| <PackageReference Include="Newtonsoft.Json" Version="12.0.02" /> | ||
| <PackageReference Include="PocketLogger" Version="0.3.0"> | ||
| <!-- Any new dependency added here must also be included in the Microsoft.DotNet.Try.Markdown, Microsoft.DotNet.Interactive and Microsoft.DotNet.Interactive.Rendering nuspec files --> | ||
| <PackageReference Include="Clockwise" Version="$(ClockwiseVersion)" /> |
There was a problem hiding this comment.
I'm really not a fan of this--we're doing something that explicitly makes things weirder and harder in the future (I acknowledge it was not your idea).
There was a problem hiding this comment.
We should actually look to remove the Clockwise dependency from here.
|
@jonsequitur Why don't we want to ship an MLS.Agent.Tools nuget package? The types within it are going to be public APIs regardless of what nuget package they ultimately appear in? |
Microsoft.DotNet.Interactive.Rendering/Microsoft.DotNet.Interactive.Rendering.nuspec
Outdated
Show resolved
Hide resolved
Microsoft.DotNet.Try.Markdown/Microsoft.DotNet.Try.Markdown.nuspec
Outdated
Show resolved
Hide resolved
jonsequitur
left a comment
There was a problem hiding this comment.
Let's try to remove the Clockwise dependency from the lower-level components. Individual recipes that depend on it would be better off moved up into MLS.Agent. A low-level utility library like MLS.Agent.Tools shouldn't bring along its own dependencies because then they spread everywhere.
|
In the latest commit, I have removed the dependency of Microsoft.Dotnet.Interactive on MLS.Agent.Tools |
| } | ||
|
|
||
| public async Task LoadExtensionsInDirectory(IDirectoryAccessor directory, KernelInvocationContext context) | ||
| public async Task LoadExtensionsInDirectory(DirectoryInfo directory, KernelInvocationContext context) |
There was a problem hiding this comment.
Since this doesn't rely directly on private state, this is a good candidate for an extension method.
Is this code C# specific?
There was a problem hiding this comment.
This method is needed for implementing the interface IExtensibleKernel
As discussed the MLS.Agent.Tools dll is a part of the Microsoft.DotNet.Interactive
We would like to publish the
Microsoft.Dotnet.InteractiveandMicrosoft.Dotnet.Interactive.Renderingpackages so that it is possible to write extensions to the kernel.This PR: