Pipeline fixes and script state access #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
reviewed
Sep 5, 2019
| | Error(ex) -> context.OnError(ex) | ||
| context.Publish(CodeSubmissionEvaluated(codeSubmission)) | ||
| context.Complete() | ||
| context.Publish(CommandHandled(codeSubmission)) |
Member
There was a problem hiding this comment.
maybe we could use the Complete to actually publish the CommandHandled ?
|
|
||
| public void Complete() | ||
| { | ||
| IsCompleted = true; |
…State access from middleware
7fb60ff to
a279e13
Compare
a279e13 to
ca027f4
Compare
84d8e40 to
7f14c0b
Compare
colombod
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where the kernel's actual command handling was happening after pipeline execution returns, rather than as the last step in the pipeline.
Fixing this unblocks the ability to see
CSharpKernel.ScriptStateeither before or after a submission is applied.