update to latest arcade SDK #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
approved these changes
Sep 12, 2019
607fd68 to
4c3cb53
Compare
4c3cb53 to
d117a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arcade is currently locked to .NET 3 preview 6, but since we need a newer version, I've not allowed auto-updates to come through because we don't want to be forced back to p6.
In an effort to bring this repo up to date I've manually updated arcade, but kept the version of the SDK at preview 7.
This also involved fixing some MSBuild warnings that are now being promoted to errors, particularly around adding
FSharp.Coreto some more projects (because XPlot pulls in a reference, but it tries to pull in 0.0 which isn't valid) and removing duplicate package references.Note that any changes under
eng/commonaren't up for review, that's the domain of arcade; there be dragons.