Use msbuild to get the path of the nuget packages #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75bd20b to
b344197
Compare
Contributor
Author
|
cc @KevinRansom |
jonsequitur
reviewed
Sep 11, 2019
jonsequitur
reviewed
Sep 11, 2019
jonsequitur
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed a way to discover KernelExtensions that are part of nuget packages that do not have a "lib" folder.
This PR uses msbuild for doing so. It adds targets which does the following things:
GeneratePathPropertyto the PackageReference property group. When this is set then in the obj folder, you will be able to see a nuget.g.props file which has a property that contains the path to the nuget package, for example,PkgFluentAssertionsThe target
ComputePackageRootsreads this property for all the nuget packages and stores the paths in itemAddedNuGetPackage.The third target prints the values from
AddedNuGetPackagetarget into a file*.nuget.pathsThen in the package restore context we read this path and try to load extensions if any are present.