这是indexloc提供的服务，不要输入任何密码
Skip to content

Move the DirectoryAccessor and related classes to MLS.Agent.Tools #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 28, 2019
Merged

Move the DirectoryAccessor and related classes to MLS.Agent.Tools #400

merged 10 commits into from
Aug 28, 2019

Conversation

@akshita31
Copy link
Contributor

@akshita31 akshita31 commented Aug 27, 2019

No description provided.

colombod
colombod reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@colombod colombod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any direct tests for the changes ? it seems they are covered by agent and workspaceserver tests only

rchande
rchande reviewed Aug 27, 2019
View reviewed changes
@akshita31
Copy link
Contributor Author

akshita31 commented Aug 27, 2019

@colombod There are tests for the Relativepath and the FileSystemDirectoryAccessor but they live in the WorkspaceServerTests.csproj and I think it is fine to leave them there for now and not create a separate test project for those.Thoughts ?

@colombod
Copy link
Member

colombod commented Aug 27, 2019

@colombod There are tests for the Relativepath and the FileSystemDirectoryAccessor but they live in the WorkspaceServerTests.csproj and I think it is fine to leave them there for now and not create a separate test project for those.Thoughts ?

If code is in project A and is only tested because consumed by project B I think this opens to a lot of troubles. if the code as moved then probably things like the simulator tests should be in a test project that targets project A.

@akshita31
Copy link
Contributor Author

akshita31 commented Aug 27, 2019

@colombod I added a separate test project which includes the test for the FileSystemDirectoryAccessor and the RelativePath classes into a separate project MLS.Agent.Tools.Tests

@akshita31 akshita31 merged commit 07e76c0 into dotnet:master Aug 28, 2019
@akshita31 akshita31 deleted the move_to_tools branch August 28, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colombod colombod colombod left review comments

@jonsequitur jonsequitur Awaiting requested review from jonsequitur

@dotnet-bot dotnet-bot Awaiting requested review from dotnet-bot

+1 more reviewer

@rchande rchande rchande approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akshita31 @colombod @rchande