-
Notifications
You must be signed in to change notification settings - Fork 563
Magic #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Magic #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
286e2fb to
39168c2
Compare
Contributor
Author
rchande
approved these changes
Aug 26, 2019
colombod
approved these changes
Aug 26, 2019
akshita31
reviewed
Aug 26, 2019
| { | ||
| public static class KernelExtensions | ||
| { | ||
| public static void VisitAllSubkernels( |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should VisitAllSubkernels be a recursive function that performs the same thing for all the subkernels of each subkernel ?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'll fix this.
1b4f441 to
792670f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the directive APIs to implement IPython-style magic commands.
I've changed the experimental
#kernel csharpdirective to be a cell-scoped language selector, enabling, e.g.:In this example "csharp" is actually the subkernel name, so this particular magic will be enabled automatically when a kernel is added to the
CompositeKernel.