这是indexloc提供的服务，不要输入任何密码
Skip to content

Verify should pass for the folder created by the demo command #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 21, 2019
Merged

Verify should pass for the folder created by the demo command #391

merged 6 commits into from
Aug 21, 2019

Conversation

@akshita31
Copy link
Contributor

@akshita31 akshita31 commented Aug 21, 2019 •
edited
Loading

Fixes: #300

  1. Renamed Insert.md--> ReadOnlySnippets.md
  2. ReadOnlySnippets should use a --project argument so that verify passes against those and users are able to execute it when using dotnet try demo

jonsequitur
jonsequitur reviewed Aug 21, 2019
View reviewed changes
@akshita31 akshita31 force-pushed the make_insert_visible branch from 68a5097 to 92577a0 Compare August 21, 2019 22:54
@akshita31 akshita31 merged commit 4b0d870 into dotnet:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonsequitur jonsequitur jonsequitur left review comments

@colombod colombod colombod approved these changes

@rchande rchande Awaiting requested review from rchande

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Insert.md from dotnet try demo seems outdated

3 participants

@akshita31 @colombod @jonsequitur