这是indexloc提供的服务，不要输入任何密码
Skip to content

Make tests depend on stable versions of packages #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Make tests depend on stable versions of packages #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45908b3
remove sdk from tutorial template tests
akshita31 Aug 15, 2019
8b4503d
use a stable version of the package
akshita31 Aug 19, 2019
192e25d
Use another package with the stable version
akshita31 Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Microsoft.DotNet.Try.ProjectTemplate.Tests/TutorialTemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ public async Task When_the_template_is_installed_verify_works()
var baseDirectory = Create.EmptyWorkspace().Directory;
var outputDirectory = baseDirectory.CreateSubdirectory("outputTemplate");
await InstallTemplateAndCreateProject(baseDirectory, outputDirectory);
var dotnet = new Dotnet(outputDirectory);
//The template targets 3.0 hence verify should run against 3.0 and not 2.1.503 used in the solution directory
await dotnet.New("global.json", "--sdk-version 3.0.100-preview6-012264");

var console = new TestConsole();
var directoryAccessor = new FileSystemDirectoryAccessor(outputDirectory);

Expand Down
2 changes: 1 addition & 1 deletion WorkspaceServer.Tests/BlazorPackageInitializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public async Task Adds_packages()
name,
new List<(string, string)>
{
("Microsoft.Extensions.Logging", "3.0.0-preview6.19304.6")
("HtmlAgilityPack", "1.11.12")
});

await initializer.Initialize(dir);
Expand Down
4 changes: 2 additions & 2 deletions WorkspaceServer.Tests/Kernel/CompositeKernelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public async Task When_SubmitCode_command_adds_packages_to_csharp_kernel_then_Pa
new CSharpKernel().UseNugetDirective()
};

var command = new SubmitCode("#r \"nuget:Microsoft.Extensions.Logging, 3.0.0-preview6.19304.6\" \nMicrosoft.Extensions.Logging.ILogger logger = null;");
var command = new SubmitCode("#r \"nuget:Microsoft.Extensions.Logging, 2.2.0\" \nMicrosoft.Extensions.Logging.ILogger logger = null;");

var result = await kernel.SendAsync(command);

Expand All @@ -84,7 +84,7 @@ public async Task When_SubmitCode_command_adds_packages_to_csharp_kernel_then_Pa
.Single()
.PackageReference
.Should()
.BeEquivalentTo(new NugetPackageReference("Microsoft.Extensions.Logging", "3.0.0-preview6.19304.6"));
.BeEquivalentTo(new NugetPackageReference("Microsoft.Extensions.Logging", "2.2.0"));

events
.Should()
Expand Down