command handling simplification, Display helper #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of creating a Display helper, I've also started some refactoring work to remove the
KernelPipelineContextand replace it with a hopefully more understandableKernelCommandBase.Handlermethod. Similar to the way ASP.NET Core middleware works, thisHandleris assignable so that the kernel can make decisions about how to implement the given command. The handler has access to theKernelInvocationContextin order to raise events much like before.I'm considering additional changes here to replace the
OnNext/OnCompleted/OnErrormethods onKernelInvocationContextwith something more specific to the use cases here.