这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix verify command #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 21, 2019
Merged

Fix verify command #380

merged 23 commits into from
Aug 21, 2019

Conversation

@akshita31
Copy link
Contributor

@akshita31 akshita31 commented Aug 16, 2019 •
edited
Loading

Fixes: #381 #310 #299

  1. If no directory has been speicified verify should take the current directory in the VerifyOptions
  2. The directory from the VerifyOptions must be used inside the VerifyCommand to create a package registry and get a directory accessor, so that it is ensured that all operations are performed with respect to the dir passed in the verify options
  3. Also fixes a bug where if we have a successful build, we were reusing workspace and any newly added files were not being included

rchande
rchande suggested changes Aug 16, 2019
View reviewed changes
rchande
rchande reviewed Aug 16, 2019
View reviewed changes
@akshita31 akshita31 force-pushed the verify_takes_current_dir_as_default branch from 37bc24e to e8b4374 Compare August 17, 2019 00:03
jonsequitur
jonsequitur reviewed Aug 19, 2019
View reviewed changes
jonsequitur
jonsequitur reviewed Aug 20, 2019
View reviewed changes
jonsequitur
jonsequitur reviewed Aug 21, 2019
View reviewed changes
jonsequitur
jonsequitur reviewed Aug 21, 2019
View reviewed changes
@akshita31 akshita31 force-pushed the verify_takes_current_dir_as_default branch from 98d3863 to 69d2ba5 Compare August 21, 2019 20:41
@akshita31 akshita31 merged commit 4214be6 into dotnet:master Aug 21, 2019
@akshita31 akshita31 deleted the verify_takes_current_dir_as_default branch August 21, 2019 21:13
This was referenced Aug 21, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonsequitur jonsequitur jonsequitur left review comments

@colombod colombod Awaiting requested review from colombod

@brettfo brettfo Awaiting requested review from brettfo

+1 more reviewer

@rchande rchande rchande approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dotnet try doesnt show error if the backing project doesnt compile in the second time

3 participants

@akshita31 @jonsequitur @rchande