xplot working in jupyter and nteract #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Aug 20, 2019
| else { | ||
| renderPlotly(); | ||
| }"); | ||
| newScript.AppendLine("</script>"); |
Contributor
There was a problem hiding this comment.
Why not use PocketView rather than add a dependency on HtmlAgilityPack?
Member
Author
There was a problem hiding this comment.
we need parsing anyway to select the div and script element from the xplot html
Contributor
There was a problem hiding this comment.
Can't they just be rendered as separate script elements?
Member
Author
There was a problem hiding this comment.
The script tag injects the other script element conditionally if requrirejs is not defined, they cannot be 2 tags
akshita31
approved these changes
Aug 20, 2019
1ae84cf to
e1aa3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle plotly loading via require js in both jupyter and nteract