这是indexloc提供的服务，不要输入任何密码

Command to install the .NET kernel #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

akshita31 merged 47 commits into dotnet:master from akshita31:install_jupyter

Aug 2, 2019

Contributor

akshita31 commented Jul 19, 2019

No description provided.

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/StringExtensions.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent.Tests/DotnetKernelJupyterInstallerTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent.Tests/DotnetKernelJupyterInstallerTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

colombod requested changes

View reviewed changes

MLS.Agent.Tests/DotnetKernelJupyterInstallerTests.cs Outdated Show resolved Hide resolved

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

colombod requested changes

View reviewed changes

MLS.Agent/DotnetKernelJupyterInstaller.cs Outdated Show resolved Hide resolved

akshita31 added 18 commits

July 29, 2019 16:43

add

17e9aa7


          add logic to create the directory

ea3a636


          copy the files

5cc75a5


          add some logging

1df0c75


          merge

6a348e8


          clean up and add more assertions

7429fb6


          merge

e49a6a8


          add interface

94aba08


          rename

570ba85


          add test

e08b06b


          add command line

4a8ee40


          refactoring to the jupyter command line

09010a0


          use the directory accessor and test

645f6a5


          add the file.copy thing

813addb


          add methods to directory accessor

b084bcc


          move files to mls.agent and remove the environment variables stuff

c3c9264


          use python exe locattion


          pass the expected things from the test

2241c0f

akshita31 force-pushed the install_jupyter branch from 1681e03 to b464aed Compare

July 31, 2019 22:44

akshita31 added 5 commits

July 31, 2019 16:24


          added a fact attribute

01c0e9e


          add list install

1aaa80c


          add inmemory kernel specs


          add test for the jupyter command line

3ad83f8


          added the new fact attribues and all tests passing

d374684

colombod requested changes

View reviewed changes

WorkspaceServer/Paths.cs Outdated Show resolved Hide resolved

akshita31 added 5 commits

August 1, 2019 13:33


          add the thing so that it gives error when the file is not found

282b5f6


          clean up

1209a75


          clean up

1c40d0a


          do not use the path, use the command directly

ec002a2


          clean up

8f77b95

akshita31 force-pushed the install_jupyter branch from d756566 to 8f77b95 Compare

August 1, 2019 21:11

akshita31 changed the title ~~WIP Command to install the .NET kernel~~ Command to install the .NET kernel

akshita31 added 3 commits

August 1, 2019 14:35


          make the test pass

60c2e9f


          add comment

ae474b8


          remove async

68aaff5

Contributor Author

akshita31 commented Aug 1, 2019 •

edited

Loading

It is working now for anaconda in windows


          make connection file optional and clean up

a19f7a6

akshita31 force-pushed the install_jupyter branch from 8e00eab to a19f7a6 Compare

August 1, 2019 23:18

jonsequitur reviewed

View reviewed changes

MLS.Agent.Tests/FactRunWhenJupyterIsInstalledAttribute.cs Outdated Show resolved Hide resolved

akshita31 added 3 commits

August 2, 2019 10:06


          use which command to execute

b3b7e93


          use Task.Run

bb7c461


          add --user

dc2101c

Contributor Author

akshita31 commented Aug 2, 2019

tested with Linux as well

akshita31 added 3 commits

August 2, 2019 11:17


          skip the test

af00826


          add timeout

b59b1f6


          rename the classes and add comment

22b2318

akshita31 merged commit 81aeca3 into dotnet:master

akshita31 deleted the install_jupyter branch

August 2, 2019 21:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet