这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@akshita31
Copy link
Contributor

@akshita31 akshita31 commented Jul 16, 2019

  1. Hosted mode scheme should be "http"
  2. Try mode scheme should be "https"

@akshita31 akshita31 changed the title Use http since hosted mode will run inside docker Use http in hosted mode Jul 16, 2019
}
},
"MLS.Agent": {
"Try": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this file to .gitignore? I'm tired of seeing it in PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it intentionally in this PR to pass the port option

@akshita31 akshita31 merged commit a44de3a into dotnet:master Jul 16, 2019
@akshita31 akshita31 deleted the again_use_http branch July 16, 2019 21:59
akshita31 added a commit to akshita31/try that referenced this pull request Jul 29, 2019
* Use http for hosted mode and https for try

* modify launch setting to pass the port

* do not launch browser in hosted mode

* no port in jupyter mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants