Should use 4242 if not in try mode #318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Closing this as this is not the intended functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we launch in try mode using Visual Studio then we launch on 4242, otherwise if we launch from the command line it runs on an arbitrary port and uses https. It would be good if the behavior when we run with F5 is the same as when the tool is run so that if there is an issue when running the tool from the command line, it can also be reproduced using F5 in Visual Studio.
The switching based on mode is also important because as per the settings we have been using so far the agent was assumed to be running on http://localhost:4242 and we should retain that behavior as we change our dockerimage to consume the tool.