Integration test #317
Merged
Integration test #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Jul 10, 2019
| using MLS.Agent.Tools; | ||
| using WorkspaceServer; | ||
|
|
||
| namespace NotIntegrationTests |
Contributor
There was a problem hiding this comment.
Well what are they then?
jonsequitur
reviewed
Jul 10, 2019
|
|
||
| if (!directory.Exists) | ||
| { | ||
| throw new Exception($"Expected packages directory {directory.FullName} to exist but it does not"); |
Contributor
There was a problem hiding this comment.
Is there a more specific exception that would be appropriate here?
brettfo
reviewed
Jul 12, 2019
| artifactName: packages | ||
| artifactType: container | ||
|
|
||
| - task: PublishBuildArtifacts@1 |
Member
There was a problem hiding this comment.
If publishing the tests like this you can remove <IsPackable>true</> from NotIntegrationTests.csproj.
added 14 commits
July 12, 2019 13:09
added 13 commits
July 16, 2019 16:06
akshita31
pushed a commit
to akshita31/try
that referenced
this pull request
Jul 29, 2019
Add an integration test leg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.