Use the project asset only if the command line succeeded #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchande
reviewed
Jun 11, 2019
rchande
reviewed
Jun 11, 2019
rchande
reviewed
Jun 11, 2019
brettfo
reviewed
Jun 18, 2019
5335e2e to
ae344d2
Compare
akshita31
added a commit
to akshita31/try
that referenced
this pull request
Jul 29, 2019
* do not make filepath as function and refactor GetProjectDirectory * add null check for the projectAsset * add exceptions to get a clearer message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check if the command line execution succeeded before we try to use the output from the results