这是indexloc提供的服务，不要输入任何密码

jupyter protocol #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

colombod merged 21 commits into dotnet:master from colombod:feature/jupyter_protocol_messages

Jun 17, 2019

Member

colombod commented Jun 7, 2019

complete message implementation

colombod requested a review from jonsequitur

June 7, 2019 15:04

colombod force-pushed the feature/jupyter_protocol_messages branch 6 times, most recently from 497cb24 to 1ed360e Compare

June 12, 2019 23:24

colombod added 11 commits

June 13, 2019 08:18


          add json connection file example

df55a76


          add missing messages

7bead8e


          use attribute and base class

38161f9


          fix problem with language Info in kernel reply

cee2676


          pdb settings

4b5fff9


          update assent test to reflect the change in message structure

f4d6949


          add default value for complete reply

65506ef


          fix parser creation to use service collection

ef393af


          remove unused usings

77a51b6


          add support for response message

360fd32


          compute cursor start for replacement

d740afd

colombod force-pushed the feature/jupyter_protocol_messages branch from 1ed360e to d740afd Compare

June 13, 2019 07:18

colombod added 3 commits

June 13, 2019 12:51


          force service collection to be passed in

86dba98


          add test for complete reply contract

ea4ea18


          simplify message builder api

450fb4f

jonsequitur reviewed

View reviewed changes

Microsoft.DotNet.Try.Jupyter/IMessageBuilder.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent.Tests/ApiViaHttpTestsBase.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

MLS.Agent/Program.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

Microsoft.DotNet.Try.Jupyter/JupyterRequestContextHandler.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

Microsoft.DotNet.Try.Jupyter/JupyterRequestContextHandler.cs Show resolved Hide resolved

colombod added 2 commits

June 13, 2019 17:50


          refactor code for reply generation and use token scan for cursor posi…

adbcdcd

…tion in complete replies


          pr settings

2d23e81

jonsequitur reviewed

View reviewed changes

Microsoft.DotNet.Try.Jupyter.Tests/HistorySerializationTests.cs Show resolved Hide resolved


          make protocol object immutable

81e2ee1

deserialize base class for jupyter message content


immutable dicitonary


missed change for immutable dicitonary

colombod force-pushed the feature/jupyter_protocol_messages branch from b3adf56 to 81e2ee1 Compare

June 17, 2019 18:49

colombod changed the title ~~WIP jupyter protocol~~ jupyter protocol

colombod requested a review from jonsequitur

June 17, 2019 18:53

jonsequitur reviewed

View reviewed changes

Microsoft.DotNet.Try.Jupyter/Protocol/InputHistoryElementConverter.cs Show resolved Hide resolved

colombod added 4 commits

June 17, 2019 20:37


          PR feedback

e22606a


          renamed method FromCommandLine

edd5a6e


          remove IMessageBuilder and concrete type

53d2279


          refactor methods

a984187

colombod merged commit 2422d10 into dotnet:master

colombod deleted the feature/jupyter_protocol_messages branch

June 17, 2019 23:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet