Make wasm package ingestion actually work #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Jun 6, 2019
| var package = new Package2(descriptor.Name, new FileSystemDirectoryAccessor(wasmAsset.DirectoryAccessor.GetFullyQualifiedRoot().Parent)); | ||
| package.Add(wasmAsset); | ||
| return package; | ||
| var package = new Package2(descriptor.Name, new FileSystemDirectoryAccessor(buildAsset.DirectoryAccessor.GetFullyQualifiedRoot().Parent)); |
Contributor
There was a problem hiding this comment.
new FileSystemDirectoryAccessor(buildAsset.DirectoryAccessor.GetFullyQualifiedRoot().Parent) [](start = 60, length = 92)
Moving to a parent directory from the asset seems like a can of worms that I feel breaks the abstraction.
We have a method, DirectoryAccessor.GetDirectoryAccessorForRelativePath, which I feel we should be using here. WebAssemblyAssetFinder should take an IDirectoryAccessor in its constructor and build one accessor from another so when we test it via the in-memory implementation, it won't break out into a file-based implementation.
jonsequitur
reviewed
Jun 6, 2019
akshita31
reviewed
Jun 6, 2019
akshita31
reviewed
Jun 6, 2019
added 5 commits
June 7, 2019 13:47
…de/wasm-package-intgestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.