check for null HtmlNode and report error #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
approved these changes
Jun 3, 2019
Member
Author
|
The <div class="notification is-danger">
<svg ...>
</svg>
Package named "console" not found.
</div>So the missing packages appears to be the root cause of most test flakiness. |
Contributor
|
I think this is a concurrency issue on creation of these package assets on-disk during test runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests have been flaky because
HtmlDocument.DocumentNodewas null which indicates an issue parsing the HTML. In an attempt to discover the issue I've added a wrapper that reports the parsed HTML ifDocumentNodewas null.Marking as work-in-progress because I expect to reset the tests repeatedly.