Add xml comments to the template #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
reviewed
Jun 3, 2019
| } | ||
|
|
||
| public static int EmptyRegion() | ||
| internal static int EmptyRegion() |
Member
There was a problem hiding this comment.
InvalidRegion sounds like a better name than EmptyRegion
There was a problem hiding this comment.
There's nothing invalid about an empty region?
rchande
reviewed
Jun 4, 2019
| ///<param name="package">Takes in the --package option from the code fence options in markdown</param> | ||
| ///<param name="project">Takes in the --project option from the code fence options in markdown</param> | ||
| ///<param name="args">Takes in any additional arguments passed in the code fence options in markdown</param> | ||
| ///<summary>This program uses <a href="https://github.com/dotnet/command-line-api/wiki/DragonFruit-overview">System.CommandLine DragonFruit</a> to accept arguments from command line. |
Contributor
There was a problem hiding this comment.
System.CommandLine DragonFruit -> System.CommandLine.DragonFruit
rchande
approved these changes
Jun 4, 2019
loic-sharma
reviewed
Jun 6, 2019
Microsoft.DotNet.Try.ProjectTemplate/Tutorial/content/Program.cs
Outdated
Show resolved
Hide resolved
rchande
approved these changes
Jun 6, 2019
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.