Use pipleline approach for projectAsset #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchande
reviewed
May 24, 2019
rchande
reviewed
May 24, 2019
rchande
reviewed
May 24, 2019
rchande
reviewed
May 24, 2019
| } | ||
|
|
||
| [Fact] | ||
| public async Task Invalidating_a_step_in_a_sequence_causes_all_successor_to_evaluate() |
There was a problem hiding this comment.
Given these semantics, shouldn't the value producer take a cancellationToken?
Contributor
There was a problem hiding this comment.
Since multiple callers can all be waiting on the same unit of work, who would be allowd to cancel?
There was a problem hiding this comment.
As we discussed, this is probably a perf optimization for invalidate, where all the successors being invalidated also have any inflight work cancelled.
jonsequitur
reviewed
May 28, 2019
jonsequitur
reviewed
May 28, 2019
akshita31
reviewed
May 28, 2019
akshita31
reviewed
May 28, 2019
| } | ||
| public interface ICreateWorkspace : IPackage | ||
| { | ||
| Task<Workspace> CreateRoslynWorkspaceAsync(Budget budget); |
Contributor
There was a problem hiding this comment.
What type of workspace will this interface create for run or for language services ?
jonsequitur
reviewed
May 29, 2019
rchande
reviewed
May 29, 2019
rchande
reviewed
May 29, 2019
rchande
reviewed
May 29, 2019
rchande
reviewed
May 29, 2019
…' into feature/project_asset_workspaces
|
@colombod Something weird happened to RoslynWorkspaceServerConsoleProjectTests.cs--it's marked as a binary file in the diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delegating project build to project asset and use of pipeline to perform steps and handle state invalidation