listen to iframe resizing and send request #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Apr 19, 2024
| abstract setPosition(position: { line: number, column: number }): void; | ||
| abstract updateOptions(options: any): void; | ||
| abstract focus(): void; | ||
| abstract layout(size?: { width: number, height: number }): void; |
Contributor
There was a problem hiding this comment.
Do we need this to be optional?
Member
Author
There was a problem hiding this comment.
this should not be optional
jonsequitur
reviewed
Apr 19, 2024
|
|
||
| private _options = {}; | ||
| private _code: string; | ||
| private _size?: { width: number; height: number; } |
Contributor
There was a problem hiding this comment.
Does this need to be optional?
Member
Author
There was a problem hiding this comment.
this is only internal state of test object, can be udnefined
jonsequitur
reviewed
Apr 19, 2024
|
|
||
| private _markers: editorAdapter.IMarkerData[]; | ||
|
|
||
| layout(size?: { width: number; height: number; } | undefined): void { |
address inconsistency in api signature again ..
21e4941 to
ceebb53
Compare
jonsequitur
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fix for resizing