Refactor pipelines to remove duplicate code #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yml Pretty much here we are using templates to replace common code
Contributor
|
Was this primarily re-arranging existing tasks or did we have to add/remove tasks as well? |
AbhitejJohn
approved these changes
Apr 19, 2024
Contributor
AbhitejJohn
left a comment
There was a problem hiding this comment.
LGTM, will let Dale/Jon who have been spending time here take a stab at a review as well though.
| @@ -0,0 +1,19 @@ | |||
| # setup-template.yml | |||
Contributor
There was a problem hiding this comment.
Could we add a comment to say that this affects both windows and linux builds here please? It should be apparent from code but wouldn't hurt to have multiple indicators.
Contributor
|
Talked with Osvaldo, he is working on updating this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are only making changes to these two pipelines:
This part of Consolidate fixes in our yml pipeline