dotnet · AbhitejJohn · Mar 29, 2024 · Mar 29, 2024 · Apr 1, 2024 · Apr 1, 2024
diff --git a/Developer-guide.ipynb b/Developer-guide.ipynb
@@ -376,11 +376,6 @@
     "\n",
     "The core of Try .NET is powered by the `CSharpProjectKernel`, which serves as the backend for .NET Interactive."
    ]
-  },
-  {
-   "cell_type": "markdown",
-   "metadata": {},
-   "source": []
   }
  ],
  "metadata": {

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -10,7 +10,8 @@
     <!-- private repo, don't do source-link -->
     <DeterministicSourcePaths>false</DeterministicSourcePaths>
     <EnableSourceLink>false</EnableSourceLink>
-
+    <PublishWindowsPdb>false</PublishWindowsPdb>
+
     <!-- NuGet: A stable release of a package should not have a prerelease dependency. -->
     <NoWarn>$(NoWarn);NU5104</NoWarn>
   </PropertyGroup>

diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -3,33 +3,35 @@
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
   </PropertyGroup>
-
   <ItemGroup>
     <PackageVersion Include="Assent" Version="2.3.2" />
     <PackageVersion Include="coverlet.collector" Version="6.0.0" />
     <PackageVersion Include="FluentAssertions" Version="6.12.0" />
-    <PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="8.0.3" />
-    <PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.Server" Version="8.0.3" />
-    <PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly" Version="8.0.3" />
-    <PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.3" />
-    <PackageVersion Include="Microsoft.DotNet.Interactive.CSharpProject" Version="1.0.0-beta.24168.2" />
-    <PackageVersion Include="Microsoft.Playwright" Version="1.41.2" />
-    <PackageVersion Include="peaky.client" Version="4.0.73" />
-    <PackageVersion Include="peaky.xunit" Version="4.0.73" />
-    <PackageVersion Include="Peaky" Version="4.0.77-beta" />
-    <PackageVersion Include="PocketLogger" Version="0.8.2" />
+    <PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="8.0.4" />
+    <PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly.Server" Version="8.0.4" />
+    <PackageVersion Include="Microsoft.AspNetCore.Components.WebAssembly" Version="8.0.4" />
+    <PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.4" />
+    <PackageVersion Include="Microsoft.DotNet.Interactive.CSharpProject" Version="1.0.0-beta.24208.2" />
+    <PackageVersion Include="Microsoft.Playwright" Version="1.42.0" />
+    <PackageVersion Include="peaky.client" Version="4.0.79" />
+    <PackageVersion Include="peaky.xunit" Version="4.0.79" />
+    <PackageVersion Include="Peaky" Version="4.0.79-beta" />
+    <PackageVersion Include="Pocket.Disposable" Version="1.2.0" />
+    <PackageVersion Include="PocketLogger.For.Xunit" Version="0.9.0" />
+    <PackageVersion Include="PocketLogger.Subscribe" Version="0.9.0" />
+    <PackageVersion Include="PocketLogger" Version="0.9.0" />
+    <PackageVersion Include="Serilog.Sinks.RollingFileAlternate" Version="2.0.9" />
+    <PackageVersion Include="Serilog" Version="2.10.0" />
     <PackageVersion Include="Swashbuckle.AspNetCore" Version="6.5.0" />
     <PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
     <PackageVersion Include="System.Drawing.Common" Version="8.0.3" />
     <PackageVersion Include="System.Net.Http" Version="4.3.4" />
     <PackageVersion Include="System.Reactive" Version="6.0.0" />
     <PackageVersion Include="System.Security.Cryptography.X509Certificates" Version="4.3.2" />
-    <PackageVersion Include="xunit" Version="2.7.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.7" />
+    <PackageVersion Include="xunit" Version="2.7.0" />
   </ItemGroup>
-
   <ItemGroup Condition="'$(DisableArcade)' == '1'">
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
   </ItemGroup>
-
 </Project>
diff --git a/Dockerfile b/Dockerfile
@@ -39,7 +39,6 @@ COPY --from=build-env /App/out .
 
 # Set up to run and expose app on port 80
 EXPOSE 80
-ENV ASPNETCORE_ENVIRONMENT=Production
 ENV ASPNETCORE_URLS=http://*:80/
 
 # This is a workaround for the fact that the Try .NET website is not yet container-aware

diff --git a/PeakyTests.ipynb b/PeakyTests.ipynb
@@ -41,7 +41,7 @@
    "outputs": [],
    "source": [
     "var tests = await peakyClient.GetTestsAsync();\n",
-    "tests"
+    "tests.Display();"
    ]
   },
   {

diff --git a/azure-pipelines-CI.yml b/azure-pipelines-CI.yml
@@ -35,10 +35,10 @@ variables:
   value: '8.0.101'
 - name: NodeJSVersion
   value: '16.13.0'
+- name: PocketLoggerLogPath
+  value: $(Build.SourcesDirectory)/artifacts/logs/pocketlogger.log
 - name: TryDotNetPackagesPath
   value: $(Build.SourcesDirectory)/artifacts/.trydotnet/packages
-- name: RunIntegrationTests
-  value: true
 - name: Codeql.Enabled
   value: true
 
@@ -86,23 +86,14 @@ extends:
               outputParentDirectory: $(Build.SourcesDirectory)/artifacts
               outputs:
               - output: pipelineArtifact
-                targetPath: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
-                artifactName: Windows_test_results_and_dumps
-                displayName: Publish Test results and Blame dumps
-                condition: failed()
-              - output: pipelineArtifact
-                targetPath: $(Build.SourcesDirectory)/artifacts/bin/Microsoft.TryDotNet.IntegrationTests/$(_BuildConfig)/net8.0/playwright_screenshots
-                artifactName: Windows_playwright_screenshots
-                displayName: Publish Playwright screen shots
+                targetPath: $(Build.SourcesDirectory)/artifacts
+                artifactName: Windows_artifacts
+                displayName: Publish Windows artifacts
                 condition: always()
-                continueOnError: true
-              # Packages are not being generated
-              # - output: pipelineArtifact
-              #   targetPath: $(Build.SourcesDirectory)/artifacts/packages/$(_BuildConfig)
-              #   artifactName: packages
-              #   displayName: Publish packages to artifacts container
 
             variables:
+            - name: RunIntegrationTests
+              value: true
             # Enable signing for internal, non-PR builds
             - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
               - group: DotNet-Blob-Feed
@@ -122,10 +113,7 @@ extends:
                       /p:DotNetPublishToBlobFeed=true
                       /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
                       /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
-                      /p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat)
-                      /p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
                       /p:OfficialBuildId=$(BUILD.BUILDNUMBER)
-                      /p:PublishToSymbolServer=true
             # else
             - ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
               - name: _SignType
@@ -171,6 +159,7 @@ extends:
                 $(_TestArgs)
               displayName: Build
               env:
+                POCKETLOGGER_LOG_PATH: $(PocketLoggerLogPath)
                 TRYDOTNET_PACKAGES_PATH: $(TryDotNetPackagesPath)
 
             - script: dotnet test -l trx --no-build --blame-hang-timeout 15m --blame-hang-dump-type full -c $(_BuildConfig) --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
@@ -204,16 +193,10 @@ extends:
               outputParentDirectory: $(Build.SourcesDirectory)/artifacts
               outputs:
               - output: pipelineArtifact
-                targetPath: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
-                artifactName: Linux_test_results_and_dumps
-                displayName: Publish Test results and Blame dumps
-                condition: failed()
-              - output: pipelineArtifact
-                targetPath: $(Build.SourcesDirectory)/artifacts/bin/Microsoft.TryDotNet.IntegrationTests/$(_BuildConfig)/net8.0/playwright_screenshots
-                artifactName: Linux_playwright_screenshots
-                displayName: Publish Playwright screen shots
+                targetPath: $(Build.SourcesDirectory)/artifacts
+                artifactName: Linux_artifacts
+                displayName: Publish Linux artifacts
                 condition: always()
-                continueOnError: true
             variables:
             # Enable signing for internal, non-PR builds
             - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
@@ -266,6 +249,7 @@ extends:
                 $(_TestArgs)
               displayName: Build
               env:
+                POCKETLOGGER_LOG_PATH: $(PocketLoggerLogPath)
                 TRYDOTNET_PACKAGES_PATH: $(TryDotNetPackagesPath)
 
             - script: dotnet test -l trx --no-build --blame-hang-timeout 15m --blame-hang-dump-type full -c $(_BuildConfig) --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -29,11 +29,10 @@ variables:
     value: '16.13.0'
   - name: TryDotNetPackagesPath
     value: $(Build.SourcesDirectory)/artifacts/.trydotnet/packages
-  - name: RunIntegrationTests
-    value: true
   - name: Codeql.Enabled
     value: true
-
+  - name: system.debug
+    value: true
 stages:
 - stage: build
   displayName: Build and Test
@@ -55,6 +54,10 @@ stages:
             name: NetCore1ESPool-Internal
             demands: ImageOverride -equals windows.vs2022.amd64
         variables:
+        - name: RunIntegrationTests
+          value: true
+        - name: POCKETLOGGER_LOG_PATH
+          value: $(Build.SourcesDirectory)\artifacts\logs\pocketlogger.log
         # Enable signing for internal, non-PR builds
         - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
           - group: DotNet-Blob-Feed
@@ -74,10 +77,7 @@ stages:
                    /p:DotNetPublishToBlobFeed=true
                    /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
                    /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
-                   /p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat)
-                   /p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
                    /p:OfficialBuildId=$(BUILD.BUILDNUMBER)
-                   /p:PublishToSymbolServer=true
         # else
         - ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
           - name: _SignType
@@ -125,42 +125,29 @@ stages:
           env:
             TRYDOTNET_PACKAGES_PATH: $(TryDotNetPackagesPath)
 
-        - script: dotnet test -l trx --no-build --blame-hang-timeout 15m --blame-hang-dump-type full -c $(_BuildConfig) --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
+        - script: dotnet test -l trx --no-build --blame-hang-timeout 15m --blame-hang-dump-type full -c $(_BuildConfig) --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig) --diag $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/diag.txt
           displayName: Test / Blame
           workingDirectory: $(Build.SourcesDirectory)
           condition: ne(variables['SkipTests'], 'true')
           env:
             RunIntegrationTests: $(RunIntegrationTests)
 
+        - script: taskkill /f /im dotnet.exe
+          displayName: Cleaning up any stale dotnet.exe processes so log collection is possible.
+          condition: ne(variables['SkipTests'], 'true')
+
         - pwsh: Get-ChildItem *.dmp -Recurse | Remove-Item
           displayName: Delete dump files
           workingDirectory: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
           condition: and(ne(variables['KeepDumps'], 'true'), ne(variables['SkipTests'], 'true'))
 
         - task: PublishBuildArtifacts@1
-          displayName: Publish Test results and Blame dumps
+          displayName: Publish Windows artifacts
           inputs:
-            pathToPublish: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
-            artifactName: Windows_test_results_and_dumps
-            artifactType: container
-          condition: failed()
-
-        - task: PublishBuildArtifacts@1
-          displayName: Publish Playwright screen shots
-          inputs:
-            pathToPublish: $(Build.SourcesDirectory)\artifacts\bin\Microsoft.TryDotNet.IntegrationTests\Release\net8.0\playwright_screenshots
-            artifactName: Windows_playwright_screenshots
+            pathToPublish: $(Build.SourcesDirectory)/artifacts/
+            artifactName: Windows_artifacts
             artifactType: container
           condition: always()
-          continueOnError: true
-
-        # Packages are not being generated
-        # - task: PublishBuildArtifacts@1
-        #   displayName: Publish packages to artifacts container
-        #   inputs:
-        #     pathToPublish: $(Build.SourcesDirectory)\artifacts\packages\$(_BuildConfig)
-        #     artifactName: packages
-        #     artifactType: container
 
   - template: /eng/common/templates/jobs/jobs.yml
     parameters:
@@ -174,6 +161,8 @@ stages:
         pool:
           vmImage: ubuntu-20.04
         variables:
+        - name: POCKETLOGGER_LOG_PATH
+          value: $(Build.SourcesDirectory)/artifacts/logs/pocketlogger.log
         # Enable signing for internal, non-PR builds
         - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
           - name: _SignType
@@ -219,6 +208,8 @@ stages:
             Write-Host "##vso[task.setvariable variable=_TestArgs]$testArg"
           displayName: Promote variables
 
+        - bash: echo $(POCKETLOGGER_LOG_PATH)
+
         - script: ./eng/cibuild.sh
             --configuration $(_BuildConfig)
             --prepareMachine
@@ -227,34 +218,37 @@ stages:
           env:
             TRYDOTNET_PACKAGES_PATH: $(TryDotNetPackagesPath)
 
-        - script: dotnet test -l trx --no-build --blame-hang-timeout 15m --blame-hang-dump-type full -c $(_BuildConfig) --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
+        - script: dotnet test -l trx --no-build --blame-hang-timeout 15m --blame-hang-dump-type full -c $(_BuildConfig) --results-directory $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig) --diag $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/diag.txt
           displayName: Test / Blame
           workingDirectory: $(Build.SourcesDirectory)
           condition: ne(variables['SkipTests'], 'true')
           env:
             RunIntegrationTests: $(RunIntegrationTests)
 
+        - pwsh: Stop-Process -Name dotnet -Force
+          displayName: Cleaning up any stale dotnet processes so log collection is possible.
+          condition: ne(variables['SkipTests'], 'true')
+
         - pwsh: Get-ChildItem *.dmp -Recurse | Remove-Item
           displayName: Delete dump files
           workingDirectory: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
           condition: and(ne(variables['KeepDumps'], 'true'), ne(variables['SkipTests'], 'true'))
 
-        - task: PublishBuildArtifacts@1
-          displayName: Publish Test results and Blame dumps
-          inputs:
-            pathToPublish: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
-            artifactName: Linux_test_results_and_dumps
-            artifactType: container
-          condition: failed()
+        # - task: PublishBuildArtifacts@1
+        #   displayName: Publish Test results and Blame dumps
+        #   inputs:
+        #     pathToPublish: $(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)
+        #     artifactName: Linux_test_results_and_dumps
+        #     artifactType: container
+        #   condition: failed()
 
         - task: PublishBuildArtifacts@1
-          displayName: Publish Playwright screen shots
+          displayName: Publish Linux artifacts
           inputs:
-            pathToPublish: $(Build.SourcesDirectory)/artifacts/bin/Microsoft.TryDotNet.IntegrationTests/Release/net8.0/playwright_screenshots
-            artifactName: Linux_playwright_screenshots
+            pathToPublish: $(Build.SourcesDirectory)/artifacts/
+            artifactName: Linux_artifacts
             artifactType: container
           condition: always()
-          continueOnError: true
 
 #---------------------------------------------------------------------------------------------------------------------#
 #                                                    Post Build                                                       #

diff --git a/eng/Versions.props b/eng/Versions.props
@@ -6,6 +6,7 @@
     <UsingToolNuGetRepack>true</UsingToolNuGetRepack>
     <UsingToolXUnit>false</UsingToolXUnit>
     <UsingToolSymbolUploader>true</UsingToolSymbolUploader>
+    <UsingToolPdbConverter>false</UsingToolPdbConverter>
     <TestRunnerAdditionalArguments>-parallel none</TestRunnerAdditionalArguments>
   </PropertyGroup>
   <PropertyGroup>