🏗 Make the dokku-update command a wee bit safer #1
Conversation
josegonzalez
left a comment
There was a problem hiding this comment.
Can we split help and run into two functions?
dokku-update
Outdated
| fi | ||
| ;; | ||
| centos | opensuse | rhel) | ||
| dokku-log-warn "Updating this operating system is not supported" |
There was a problem hiding this comment.
We should add centos support here or just decide to kill it entirely?
There was a problem hiding this comment.
I wonder… CentOS is not mentioned in the landing page’s Quick-start instructions (only Debian and Arch) and I think I heard something about CentOS becoming a rolling-updates type distribution, so I wonder if a lot of people will migrate away in disgust, because that sounds like something people would not like about CentOS… What do you think? I don’t mind either way really, just need a list of packages in case we keep supporting it.
There was a problem hiding this comment.
Lets support it until we decide to EOL CentOS. It doesn't cost me anything to support atm.
Here is the fpm command which includes centos deps: https://github.com/dokku/dokku/blob/master/rpm.mk#L28
There was a problem hiding this comment.
Added but not really tested 😬 Just went through CentOS/RHEL/OpenSUSE package manager documentation and made an educated guess…
|
@Cellane friendly bump :) |
|
Sorry! Totally slipped my mind 😢 |
|
I'll work on getting releases going tomorrow for this. Do you mind making a PR for the core repo to remove the dokku-update codebase and it's release code? |
References dokku/dokku#4305
A few notes:
dokku-event-listenermissing, is that expected?