Fixes permissions issues #6
Conversation
|
Thanks for the PR! I really like all the improvements 👍 Regarding the permissions of the certificates, the previous strategy which was working on my system (Ubuntu 14.04 LTS running dokku 0.4.4) was that everything under the Could you find out for me how the ownership/permissions looked on your system before making the ownership and permissions changes on your PR? I'm still hoping for a simpler solution that doesn't need permission fixing :-) |
|
Does |
|
Yes, both |
|
OK, let me see if changing the group permissions on folders will stick. Then the second |
…her cleanup. Also Shellshock fixes
|
Alright! This works for me. I basically just copied the No more second |
|
Awesome! Thanks so much for this, this has improved the plugin greatly! |
|
Sweet. You need to get this plugin listed on http://dokku.viewdocs.io/dokku/plugins/ Probably should emphasize the 'zero-downtime' aspect. |
|
PR is filed: dokku/dokku#1779 |
|
Nice! It's been working too well for me, they cut me off and now I have to On Wed, Dec 16, 2015, 12:33 AM Stefan Seemayer notifications@github.com
|
So this is kind of large, sorry. Feel free to pick it apart in to your own changes if you'd like. I won't mind 😄
The main change here is to fix the permissions of certificates. I'm not sure how it was working for people before (was it?), but the letsencrypt docker container was creating certs with root permissions and dokker couldn't use them. I added another
docker runcommand to fix this. Otherwise I had to manually fix the permissions and rerunnginx:build-config.Anyway, I also cleaned some other stuff up, like simplifying the command to
letsencrypt <app>. I also fixed the README to includesudowhen installing along with other things.Cheers!