Improve Dockerfile example/test #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placing `COPY` (or `ADD`) of the application directory after the `RUN apt-get install ...` statements will allow the layers created from those statements to be retrieved from docker's cache on subsequent runs.
Closed
Member
|
Odd, this isn't running under CircleCI. I've reached out to support to see what that's all about. I'd like to ensure the tests pass before merging :) |
Contributor
Author
|
👍 |
Member
|
I believe @techniq will need to follow the fork in CircleCi for it to run tests. |
josegonzalez
added a commit
that referenced
this pull request
Feb 19, 2015
Improve Dockerfile example/test
Contributor
Author
|
I don't know if this helped by I added by fork to CircleCI early today when I saw @michaelshobbs comment: https://circleci.com/gh/techniq/dokku |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placing
COPY(orADD) of the application directory after theRUN apt-get install ...statements will allow the layers created from those statements to be retrieved from docker's cache on subsequent runs.