这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@alessio
Copy link
Contributor

@alessio alessio commented Jan 31, 2015

Strip the header out the apps list to make the output machine-parseable.

- Strip out the header in the apps list to make the output
  machine-parseable.
@michaelshobbs
Copy link
Member

I'm fine with idea of output without the header. However, I don't know that we should introduce long form modifiers and it's kind of an odd implementation. I mean completely functional of course if not a bit complex. @josegonzalez any feedback or thoughts here?

@alessio
Copy link
Contributor Author

alessio commented Feb 3, 2015

A shorter one (e.g. -s) would work too as well as grepping $@ for such flag.
Thanks for considering though!

@josegonzalez
Copy link
Member

Well, should all output be machine parseable? I've been thinking about this for a long time, as my dashboard currently parses the dokku output into something it can use. The more I think about it, the less I like dokku's current bash implementation, as it makes argument parsing a bit weird, and can't be used as a library.

Not really strong on this PR, as I think there are other places where people will want this sort of functionality as well :|

@alessio
Copy link
Contributor Author

alessio commented Feb 4, 2015

Users may appreciate it since AFAICS it's pretty common to use dokku as a component of complex deployment pipelines.

@alessio
Copy link
Contributor Author

alessio commented Feb 5, 2015

I've simplified the command line parsing and replaced the long option with a shorter one (s/--short/-s/)

michaelshobbs added a commit that referenced this pull request Feb 5, 2015
@josegonzalez
Copy link
Member

Closing in favor of #949

michaelshobbs added a commit that referenced this pull request Feb 6, 2015
first stab at a common functions library. include argument parsing and a few definitions wired up. closes #932. closes #945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants