Skip building buildstep if SKIP_BUILD_STACK set. Useful for building dokku inside docker. #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Here is my Dockerfile for reference |
Member
|
I get where you're coming from here. I'm on the fence though. @josegonzalez do you have any strong opinions here? |
Member
|
I'd prefer if we can detect whether the socket is accessible rather than have an env var... |
michaelshobbs
added a commit
that referenced
this pull request
Feb 2, 2015
Member
|
@lsde @josegonzalez please have a look at #936 |
Author
|
well i agree this is a better solution. |
josegonzalez
added a commit
that referenced
this pull request
Feb 3, 2015
…tack only execute build stack if we have access to /var/run/docker.sock. closes #929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building dokku inside docker itself, the 'stack' step fails because of unaccessible /var/run/docker.sock, which cannot be bound via Dockerfile.
Thus, the only option is to skip that step and instead pull 'progium/buildstep' directly from docker Hub.
Something like 'ENV SKIP_BUILD_STACK=YES' in Dockerfile is assumed.