-
-
Notifications
You must be signed in to change notification settings - Fork 2k
support both docker-args PHASE and docker-args-PHASE for the time being. closes #906 #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
refs: #896 |
|
If it wasn't clear, these are two mutually exclusive ways of handling the docker-args pluginhooks. Your plugin needs to move over to the new style docker-args-PHASE and drop the old style at the same time otherwise the pluginhook will be called twice as dokku is supporting both styles for the interim. |
|
👍 |
|
Note: this will take effect once 0.4.0 comes out (which is only being released for this change). |
|
I'll update the code comment |
7a28877 to
9136054
Compare
9136054 to
1b22f69
Compare
|
So basically once this is merged, we need to do a 0.4.0 release. Do you want me to do a 0.3.14 release and then a 0.4.0 release with this change? We can back out the previous change to add |
|
I think this is fine for a 0.3.14 release as it doesn't break anything. Then 0.4.0 would include the removal of |
|
Ah gotcha, didn't think of that. I'll merge then and release later today. |
…hooks support both docker-args PHASE and docker-args-PHASE for the time being. closes #906
The idea here is to support docker-args more granularly by phase. See #896 and #906.