这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@michaelshobbs
Copy link
Member

The idea here is to support docker-args more granularly by phase. See #896 and #906.

@michaelshobbs
Copy link
Member Author

refs: #896

@michaelshobbs
Copy link
Member Author

ping docker-args pluginhook authors
@ohardy
@stuartpb
@sehrope
@dyson
@alex-sherwin
@rlaneve

@dyson
Copy link
Contributor

dyson commented Jan 30, 2015

If it wasn't clear, these are two mutually exclusive ways of handling the docker-args pluginhooks. Your plugin needs to move over to the new style docker-args-PHASE and drop the old style at the same time otherwise the pluginhook will be called twice as dokku is supporting both styles for the interim.

@michaelshobbs
Copy link
Member Author

👍

@josegonzalez
Copy link
Member

Note: this will take effect once 0.4.0 comes out (which is only being released for this change).

@michaelshobbs
Copy link
Member Author

I'll update the code comment

@michaelshobbs michaelshobbs force-pushed the 906-mh-docker-args-phase-pluginhooks branch from 7a28877 to 9136054 Compare January 30, 2015 02:31
@michaelshobbs michaelshobbs force-pushed the 906-mh-docker-args-phase-pluginhooks branch from 9136054 to 1b22f69 Compare January 30, 2015 02:33
@josegonzalez
Copy link
Member

So basically once this is merged, we need to do a 0.4.0 release. Do you want me to do a 0.3.14 release and then a 0.4.0 release with this change? We can back out the previous change to add run to docker args, release 0.3.14, un-back out and merge this, then release 0.4.0 as well.

@michaelshobbs
Copy link
Member Author

I think this is fine for a 0.3.14 release as it doesn't break anything. Then 0.4.0 would include the removal of docker-args PHASE. Or am I misunderstanding?

@josegonzalez
Copy link
Member

Ah gotcha, didn't think of that. I'll merge then and release later today.

josegonzalez added a commit that referenced this pull request Feb 4, 2015
…hooks

support both docker-args PHASE and docker-args-PHASE for the time being. closes #906
@josegonzalez josegonzalez merged commit 72a58bb into master Feb 4, 2015
@josegonzalez josegonzalez deleted the 906-mh-docker-args-phase-pluginhooks branch February 4, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants