implement rebuild command that reuses git_archive_all #925
Conversation
There was a problem hiding this comment.
When running locally from a directory that the dokku user didn't have access to, it would cause the deployment to fail because of pipefail. Additionally, it was unnecessary as it was being executed in a subshell anyway.
There was a problem hiding this comment.
Shouldn't the command be re-executed as the dokku user via the dokku command?
There was a problem hiding this comment.
It is and that seems to be the issue. Try adding that line back without the > /dev/null and running ps:rebuild <app> from ~root/dokku. It throws /var/lib/dokku/plugins/git/commands: line 16: popd: /root/dokku: Permission denied
Basically we pushd $TMP_WORK_DIR as the dokku user and that puts ~root/dokku on the stack. Then popd as dokku fails to cd back to ~root/dokku.
|
@michaelshobbs Did you look at the dokku-alt implementation? |
|
@vincentfretin 👍 I'll take a look at implementing something similar |
|
Ugh. I really don't like that locked/unlocked case pattern....I want to noodle on this a bit. Any additional thoughts are surely welcomed. |
|
Why don't you like the locking pattern? |
|
To clarify, I like I'm about to push up a functional implementation that uses a similar Please bang on it and rip it to shreds if its crap. |
|
👍 feel free to merge when ready :) |
implement rebuild command that reuses git_archive_all
rebuilds an app using the same functionality as a regular deploy and thus supports git submodules. comments welcome!