这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@michaelshobbs
Copy link
Member

closes #552
closes #913

@josegonzalez
Copy link
Member

@michaelshobbs please ref the issues in your commit message as well, it lets github automatically close issues if the "closes #derp" is in the commit message when merged.

@josegonzalez
Copy link
Member

+1 Merge when ready.

@michaelshobbs
Copy link
Member Author

Oh crap. I thought I did but on a new line in the commit.

@michaelshobbs
Copy link
Member Author

I know I didn't do it on the first push. I'll double check when I get back to my compy.

@michaelshobbs michaelshobbs force-pushed the 552-913-conditional-tty-on-run branch from cc00c5d to 3e100e3 Compare January 22, 2015 00:40
@michaelshobbs
Copy link
Member Author

Ha! That was it. Just forgot to push after I amended the commit msg.

michaelshobbs added a commit that referenced this pull request Jan 22, 2015
conditionally set interactive and tty on dokku run
@michaelshobbs michaelshobbs merged commit 55892d7 into master Jan 22, 2015
@josegonzalez josegonzalez deleted the 552-913-conditional-tty-on-run branch January 22, 2015 02:24
@timbueno
Copy link

I believe this commit broke executing the TTY and Interactive functionality of my Flask-Script commands. I can no longer get a python prompt when executing dokku run my_app python manage.py shell or any other commands that require a prompt. Commands that do not require interactivity work fine.

It seems like [[ ! -z "$PS1" ]] doesn't evaluate when in a script - but in the prompt it works just fine.

@michaelshobbs
Copy link
Member Author

Confirmed. Let me see what I can do. Would you mind opening a new issue to track this?

@michaelshobbs
Copy link
Member Author

@timbueno see #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

level="fatal" msg="cannot enable tty mode on non tty input" Output of dokku "run" commands not shown when run in non-interactive mode

4 participants