Core improvements #777
Closed
Core improvements #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2014 11:38
To be able to set some other environment variables even if dokku gets called from a different user we have to keep the environment with sudo intact, so i added the -E option.
To be able to switch the plugin path i have removed the hard coded plugin path from the catch all section of the switch within the main dokku executable.
Member
|
Looks good. I'm a bit worried about the |
Contributor
Author
I played around with dokku while i tried to package it and was wondering why i don't get other paths running with environment variables. As i did not run the tests with the dokku user it simply did not take over the environment variables without the -E option. |
Member
|
Oh I meant docs in the docs folder, so that others are aware of how that works. |
josegonzalez
added a commit
that referenced
this pull request
Nov 24, 2014
Member
|
Merged in 53c58ec. Thanks for the pull request, and looking forward to full SUSE support :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some improvements as you can see on the separate commits like keeping the environment for sudo, replaced hard coded plugin paths
This pull request have been split from #751.